Page 1 of 1

Underscores - filenames & generated names

Posted: Sat Dec 01, 2018 5:28 am
by mbb
P2VR seems to have issues with underscores in file names.

"pano_b.tif, pano_f.tif etc, etc" becomes "pano_" instead of "pano"

Converting the above cube to equi via P2VR creates file names with 2x underscores by default eg: "pano__equi.tif" vs "pano_equi.tif"

Double underscores, ever, are just weird and other than some special programming syntax cases there's no reason to be doing that.

Just thought I would mention it, for perhaps a reevaluation in how these are handled? I think if your app knows that files are cube faces, and which cube faces, then why not just get rid of whatever was indicating such when setting the new name no?

Re: Underscores - filenames & generated names

Posted: Tue Dec 04, 2018 8:51 pm
by Hopki
Hi Bradford,
When converting images Pano2VR adds an underscore and then file type prefix.

If you have an input cube face name of pano_f, then Pano2VR sees the underscore as part of the file name.
This is because Pano2VR does not use the underscore with cube face file name conversion when using f, b etc.

Example,
If you add an Equirectangular image to Pano2VR and clicked the convert button and select cube faces you will see the naming conventions:

Screenshot 2018-12-04 at 19.39.36.png
Screenshot 2018-12-04 at 19.39.36.png (18.73 KiB) Viewed 3008 times

So Pano2VR would name the cube faces panof.jpg, panob.jpg etc.
When converted back to an equirectangular image you would get pano_equi.jpg
Regards,
Hopki

Re: Underscores - filenames & generated names

Posted: Wed Dec 05, 2018 4:01 am
by mbb
If you have an input cube face name of pano_f, then Pano2VR sees the underscore as part of the file name.
This is because Pano2VR does not use the underscore with cube face file name conversion when using f, b etc.
This is incorrect. Hence why I posted about the issue.

To reproduce, drag cube faces for more than one panorama into the program.

Select all, then convert all to equirectangular. Leave everything at their defaults.

You will see that all exported equirectangular images have double underscores in their names.

Re: Underscores - filenames & generated names

Posted: Wed Dec 05, 2018 10:49 pm
by Hopki
Hi,
The developers have looked at this and say that they are able to remove the underscore in the file name that is being generated by the KRPano droplet.
Regards,
Hopki

Re: Underscores - filenames & generated names

Posted: Thu Dec 06, 2018 10:57 pm
by mbb
Sorry I do not understand your response-

Do you mean that the developers looked into it and they don't see a problem because they are able to remove the underscore, or that they are able to remove it so they will fix the program?

Additionally, it's not just krpano that names cube faces that way, regular people can do it to just by typing out "pano_b, pano_f, pano_l..." etc